home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 42863294

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/125#issuecomment-42863294 https://api.github.com/repos/pydata/xarray/issues/125 42863294 MDEyOklzc3VlQ29tbWVudDQyODYzMjk0 1217238 2014-05-12T17:39:35Z 2014-05-12T17:39:35Z MEMBER

Wow, that is nasty! As you can see, we currently have a lot of awkward hacks to work around numpy's semi-broken datetime64, and it looks like this fix broke some of them -- hence the failing Travis builds.

Maybe we need some special logic in Variable.concat instead? My guess is that the trouble here is related to all these datetime64 objects (plain np.datetime64 objects, not arrays with dtype='datetime64', because 0-dimensional datetime64 arrays are broken) being put into an array directly, which at some point implicitly converts them into integers.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  33307883
Powered by Datasette · Queries took 79.985ms · About: xarray-datasette