issue_comments: 427927907

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2473#issuecomment-427927907 https://api.github.com/repos/pydata/xarray/issues/2473 427927907 MDEyOklzc3VlQ29tbWVudDQyNzkyNzkwNw== 1217238 2018-10-08T18:06:23Z 2018-10-08T18:06:23Z MEMBER

Your use of an xarray accessor class looks a little funny to me. Accessors should only accept one argument, which is an xarray.Dataset. If you want to make your own objects, that's fine, but I don't think there's any point in making them an accessor.

What does your extra_data look like? Would it be possible to put it into xarray in the form of coordinates or attributes? If so, that would probably be the preferred path.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   367763373