issue_comments: 426330320

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2451#issuecomment-426330320 https://api.github.com/repos/pydata/xarray/issues/2451 426330320 MDEyOklzc3VlQ29tbWVudDQyNjMzMDMyMA== 1217238 2018-10-02T16:00:13Z 2018-10-02T16:00:22Z MEMBER

+1 for adding a fill_value argument to shift().

-1 for changing the behavior for shift=0 in particular. It's generally not a good idea to make the type/dtype of the result of operations dependent on the values of input arguments -- that sort of things can easily lead to bugs.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   365526259