home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 420084948

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1613#issuecomment-420084948 https://api.github.com/repos/pydata/xarray/issues/1613 420084948 MDEyOklzc3VlQ29tbWVudDQyMDA4NDk0OA== 98330 2018-09-10T22:40:15Z 2018-09-10T22:41:58Z NONE

The justification for this logic is that sel/loc would work like normal indexing [] on a Python list, and if you supply slice limits in the opposite order on a Python list, you get an empty result.

Given that sel is label/value-based, I don't see how the analogy with positional list-based indexing applies. This behavior looks like a functional bug. If you have decided to keep it as is, I'd suggest at the very least to add a warning if an empty dataset is returned because values in an attribute are ordered high...low.

EDIT: also then best to close this issue as wontfix

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  263403430
Powered by Datasette · Queries took 79.106ms · About: xarray-datasette