issue_comments: 419202871

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2368#issuecomment-419202871 https://api.github.com/repos/pydata/xarray/issues/2368 419202871 MDEyOklzc3VlQ29tbWVudDQxOTIwMjg3MQ== 1217238 2018-09-06T18:51:11Z 2018-09-06T18:51:11Z MEMBER

Currently, xarray requires that variables with a name matching a dimension are 1D variables along that dimension, e.g., python for dim in dataset.dims: if dim in dataset.variables: assert dataset.variables[dim].dims == (dim,)

I agree that this unnecessarily complicates our data model. There's no particular advantage to this invariant, besides removing the need to check the dimensions of variables used for indexing lookups. I'm sure there are some cases internally where we currently rely on this assumption, but it should be relatively easy to relax.

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   350899839