issue_comments: 415082921

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2261#issuecomment-415082921 https://api.github.com/repos/pydata/xarray/issues/2261 415082921 MDEyOklzc3VlQ29tbWVudDQxNTA4MjkyMQ== 1217238 2018-08-22T15:54:09Z 2018-08-22T15:54:09Z MEMBER

ASV benchmark results for the dataset io tests (created with asv continuous -f 1.1 -E conda-py3.6-bottleneck-dask-netcdf4-numpy-pandas-scipy upstream/master HEAD -b dataset_io): 193.14ms before after ratio [0b9ab2d1] [6350ca6f] + 56.76ms 68.17ms 1.20 dataset_io.IOReadMultipleNetCDF3Dask.time_open_dataset_netcdf4_with_block_chunks_multiprocessing + 367.54ms 426.44ms 1.16 dataset_io.IOReadSingleNetCDF3Dask.time_load_dataset_netcdf4_with_time_chunks_multiprocessing - 83.44ms 74.41ms 0.89 dataset_io.IOReadMultipleNetCDF4Dask.time_open_dataset_netcdf4_with_time_chunks - 1.39s 1.24s 0.89 dataset_io.IOReadMultipleNetCDF4Dask.time_load_dataset_netcdf4_with_block_chunks_multiprocessing - 3.19s 2.83s 0.89 dataset_io.IOReadSingleNetCDF3Dask.time_load_dataset_scipy_with_block_chunks_oindexing - 435.48ms 384.63ms 0.88 dataset_io.IOReadSingleNetCDF3Dask.time_load_dataset_scipy_with_time_chunks - 65.69ms 57.92ms 0.88 dataset_io.IOReadMultipleNetCDF3Dask.time_open_dataset_netcdf4_with_block_chunks - 1.08s 931.72ms 0.86 dataset_io.IOReadMultipleNetCDF3Dask.time_load_dataset_scipy_with_time_chunks - 1.09s 938.76ms 0.86 dataset_io.IOReadMultipleNetCDF4Dask.time_load_dataset_netcdf4_with_time_chunks_multiprocessing - 190.29ms 160.28ms 0.84 dataset_io.IOReadSingleNetCDF3Dask.time_load_dataset_scipy_with_block_chunks_vindexing - 274.98ms 229.61ms 0.83 dataset_io.IOReadMultipleNetCDF4Dask.time_load_dataset_netcdf4_with_time_chunks - 102.61ms 83.37ms 0.81 dataset_io.IOReadMultipleNetCDF3Dask.time_open_dataset_scipy_with_block_chunks - 88.31ms 70.94ms 0.80 dataset_io.IOReadMultipleNetCDF4Dask.time_open_dataset_netcdf4_with_time_chunks_multiprocessing - 595.90ms 476.80ms 0.80 dataset_io.IOReadMultipleNetCDF4.time_load_dataset_netcdf4 - 683.88ms 546.81ms 0.80 dataset_io.IOReadMultipleNetCDF4Dask.time_load_dataset_netcdf4_with_block_chunks - 83.22ms 63.94ms 0.77 dataset_io.IOReadMultipleNetCDF4Dask.time_open_dataset_netcdf4_with_block_chunks_multiprocessing - 81.28ms 60.12ms 0.74 dataset_io.IOReadMultipleNetCDF4Dask.time_open_dataset_netcdf4_with_block_chunks - 134.39ms 99.27ms 0.74 dataset_io.IOReadSingleNetCDF3.time_load_dataset_scipy - 100.06ms 63.71ms 0.64 dataset_io.IOReadMultipleNetCDF3Dask.time_open_dataset_scipy_with_time_chunks - 811.28ms 499.11ms 0.62 dataset_io.IOReadMultipleNetCDF3.time_load_dataset_scipy - 29.88ms 18.12ms 0.61 dataset_io.IOReadSingleNetCDF3.time_orthogonal_indexing - 102.23ms 59.25ms 0.58 dataset_io.IOReadMultipleNetCDF3.time_open_dataset_scipy

Most of the changed benchmarks have improved by ~20%, with the exceptions of dataset_io.IOReadMultipleNetCDF3Dask.time_open_dataset_netcdf4_with_block_chunks_multiprocessing and dataset_io.IOReadSingleNetCDF3Dask.time_load_dataset_netcdf4_with_time_chunks_multiprocessing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   337267315