home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 413774281

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2370#issuecomment-413774281 https://api.github.com/repos/pydata/xarray/issues/2370 413774281 MDEyOklzc3VlQ29tbWVudDQxMzc3NDI4MQ== 6815844 2018-08-17T06:48:54Z 2018-08-17T06:48:54Z MEMBER

Right now bottleneck is automatically chosen if it is installed, which is rather annoying since the xarray recipe on conda-forge ships with bottleneck even though it should be an optional dependency.

I didn't notice that. I also think that bottleneck should be an optional dependency. @shoyer, can you check this? Maybe this file defines dependency?

Perhaps we could make it possible to to set the ops engine (to either numpy or bottleneck) and dtype (float32, float64) via set_options()

I think this is a reasonable option.

Personally, I think we can consider to stop using bottleneck entirely or make it completely optional. With dask backend, bottleneck is not being used and we use this konly in nan-aggregation methods for numpy backend and the rolling operation. After #1837, our rolling with pure numpy is not terriblly slow compared with bottleneck.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  351000813
Powered by Datasette · Queries took 1.049ms · About: xarray-datasette