issue_comments: 413398724

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2370#issuecomment-413398724 https://api.github.com/repos/pydata/xarray/issues/2370 413398724 MDEyOklzc3VlQ29tbWVudDQxMzM5ODcyNA== 6815844 2018-08-16T02:01:38Z 2018-08-16T02:02:29Z MEMBER

After #2236, sum(skipna=False) will use numpy function even if bottleneck is installed. But in other cases, we still use bottleneck.

I am actually not sure that the automatically casting to float64 or switching to numpy function are the correct path. Some people may want to use float32 for saving memory and some other people may want to use bn.nansum as it is more efficient than numpy's counterpart. The best algorithm may depend on usecases.

My proposal is to make these method more explicit, e.g. supporting engine='bottleneck' keyword.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   351000813