issue_comments: 412495621

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2304#issuecomment-412495621 https://api.github.com/repos/pydata/xarray/issues/2304 412495621 MDEyOklzc3VlQ29tbWVudDQxMjQ5NTYyMQ== 10050469 2018-08-13T12:04:10Z 2018-08-13T12:04:10Z MEMBER

I think we are still talking about different things. In the example by @Thomas-Z above there is still a problem at the line:

```python

Comparing both dataframes with float32 precision (1e-6)

mask = np.isclose(df_nc['var'], df_xr['var'], rtol=0, atol=1e-6) ```

As discussed several times above, this test is misleading: it should assert for atol=0.01, which is the real accuracy of the underlying data. For this purpose float32 is more than good enough.

@shoyer said:

I would be happy to add options for whether to default to float32 or float64 precision.

so we would welcome a PR in this direction! I don't think we need to change the default behavior though, as there is a slight possibility that some people are relying on the data being float32.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   343659822