home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 412407141

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1560#issuecomment-412407141 https://api.github.com/repos/pydata/xarray/issues/1560 412407141 MDEyOklzc3VlQ29tbWVudDQxMjQwNzE0MQ== 1217238 2018-08-13T04:44:09Z 2018-08-13T04:44:09Z MEMBER

@maahn yes, that would look fine to me. Please add an ASV benchmark so we can monitor this for regressions: https://github.com/pydata/xarray/tree/master/asv_bench/benchmarks

It would be nice to push this up this optimization into reindex_variables, but it's not necessary (and I'm not even sure it could be done as efficiently as the equals check in unstack).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  255989233
Powered by Datasette · Queries took 0.679ms · About: xarray-datasette