issue_comments: 411461794

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2330#issuecomment-411461794 https://api.github.com/repos/pydata/xarray/issues/2330 411461794 MDEyOklzc3VlQ29tbWVudDQxMTQ2MTc5NA== 5635139 2018-08-08T16:08:36Z 2018-08-08T16:08:36Z MEMBER

@fmaussion good question

The main reason I think this is worthwhile is the change in behavior between 0.10.x and 0.11.0, when iterating over a Dataset will iterate only over its data_vars, and so will change Dataset(ds) from ds to Dataset(ds.data_vars). I don't have a strong view on which option we choose, but I do think we should have a deliberate decision rather than making a breaking-change-by-coincidence.

To answer your question though, we hit this when inheriting from a Dataset: the object is initialized with a dataset, which is super-ed up to the Dataset constructor. (I realize this is narrow!). Alternatively, there is another repo that linked to the issue here

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   346294369