issue_comments: 411258309

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2330#issuecomment-411258309 https://api.github.com/repos/pydata/xarray/issues/2330 411258309 MDEyOklzc3VlQ29tbWVudDQxMTI1ODMwOQ== 1217238 2018-08-08T01:56:04Z 2018-08-08T01:56:04Z MEMBER

Now I'm having second thoughts. It does make me a little nervous to add special cases that distinguish between xr.Dataset(ds, coords=some_coords) and xr.Dataset(ds.data_vars, coords=some_coords).

Maybe my proposed solution above is too complex, and it would be better simply to default the coords and attrs argument to those arguments from a passed Dataset object. This is basically what we do for DataArray.

That said, I do think we should try to resist the notion that every class constructor must also work for coercion to that class. This tends to result in a slightly confused interface. A separate as_dataset() function (even in user code) could give exactly the desired result in only be a few lines of code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   346294369