issue_comments: 411222843

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1875#issuecomment-411222843 https://api.github.com/repos/pydata/xarray/issues/1875 411222843 MDEyOklzc3VlQ29tbWVudDQxMTIyMjg0Mw== 1217238 2018-08-07T22:25:16Z 2018-08-07T22:25:16Z MEMBER

Yes, it would be nice to change this to behavior (1) above.

There are a few options here:

  • Just change how roll works (as a breaking change) in xarray v0.11, with the argument that the current behavior is broken/useless. This is easiest if we aren't concerned about backwards compatibility, but unfortunately I'm pretty sure at least some people rely on this, e.g., based this StackOverflow post.
  • Deprecate the current behavior, e.g., by inserting a new argument coords=None which by default shifts coordinates (equivalent to coords=True) and raises a warning. In a future version of xarray, switch the default to coords=False.
  • Implement the desired behavior in a new function (roll_axis?) and deprecate roll. This is the preferred option for mature projects like NumPy.

I am loathe to loose the name roll so this second option is probably the best choice. Any interest in putting together a pull request?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   293345254