home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 410963647

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2346#issuecomment-410963647 https://api.github.com/repos/pydata/xarray/issues/2346 410963647 MDEyOklzc3VlQ29tbWVudDQxMDk2MzY0Nw== 1492047 2018-08-07T07:37:06Z 2018-08-07T07:37:06Z CONTRIBUTOR

I was kind of expecting to get the order shown when looking at the dims property but i understand your point and it makes sense.

Two things are still bothering me though: - ds['foo'].to_dataframe() and ds[['foo']].to_dataframe() might have different results - if we want to have a specific order we have to apply reorder_levels and sort_index which can be quite expensive.

For the first point I don't think anything should be done, it's a special case and even if it could be easily tested it might be ugly. For the second point I would not change anything to the way the order is defined now, it's consistent and easily predictable. Instead I would add an additional optional parameter to to_dataframe() (the one from _to_dataframe(ordered_dims)) to allow the user to get the order he wants.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  347895055
Powered by Datasette · Queries took 0.523ms · About: xarray-datasette