issue_comments: 410046100

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2330#issuecomment-410046100 https://api.github.com/repos/pydata/xarray/issues/2330 410046100 MDEyOklzc3VlQ29tbWVudDQxMDA0NjEwMA== 1217238 2018-08-02T19:46:57Z 2018-08-02T19:46:57Z MEMBER

An alternative approach - more friendly but less explicit - is for any other argument (coords, attrs) supplied to overwrite the Dataset's

I think this would be slightly preferred, and also more consistent with the model of a Dataset as only iterating over data_vars. This suggests that at the very least, Dataset(ds) and Dataset(ds.data_vars) should be consistent after we finish the changes described in https://github.com/pydata/xarray/issues/884. Note that ds.data_vars will pull in coordinates associated with the DataArray objects.

To be more precise, I would probably make: ds2 = Dataset(ds1, coords, attrs) equivalent to ds2 = ds1.copy() ds2.coords.update(coords) ds2.attrs.update(attrs)

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   346294369