issue_comments: 408642640

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2261#issuecomment-408642640 https://api.github.com/repos/pydata/xarray/issues/2261 408642640 MDEyOklzc3VlQ29tbWVudDQwODY0MjY0MA== 1217238 2018-07-29T00:03:57Z 2018-07-29T00:03:57Z MEMBER

As an experiment, I rewrote the SciPy netCDF backend to use FileManager: - The code is now significantly simpler -- all the ensure_open() business could simply be removed. - We used to see a bunch of warnings about not closing memory mapped files ("RuntimeWarning: Cannot close a netcdf_file opened with mmap=True, when netcdf_variables or arrays referring to its data still exist."). These have all gone away! - compute=False now magically works (I only had to remove the explicitly raised error!)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   337267315