issue_comments: 408268331

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2315#issuecomment-408268331 https://api.github.com/repos/pydata/xarray/issues/2315 408268331 MDEyOklzc3VlQ29tbWVudDQwODI2ODMzMQ== 950575 2018-07-26T23:44:49Z 2018-07-26T23:44:49Z CONTRIBUTOR

I can work on a PR tomorrow. Does the benefit of having the same behavior as the netCDF4 library warrant a potentially breaking change for existing code which relies on the current behavior of filter_by_attrs()?

IMO, yes.

This might need adding a new method with the same behavior as netCDF4 and keeping the existing one as is (with appropriate documentation updates).

That is up to xarray devs but I personally don't think it is necessary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   344631360