home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 407076380

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2277#issuecomment-407076380 https://api.github.com/repos/pydata/xarray/issues/2277 407076380 MDEyOklzc3VlQ29tbWVudDQwNzA3NjM4MA== 6164157 2018-07-23T14:25:17Z 2018-07-23T14:25:17Z CONTRIBUTOR

thanks @dcherian for the review. I'll fix the code when I get to it later this week,

Regarding the size and marker style - I'm not sure it makes sense to duplicate this functionality. Is it not easier to stack the two data arrays into one, use to_pandas and then just use seaborn directly? The reason I started this PR in the first place is that I happened to do relatively simple scatter plots quite often, so I thought it'd be handy. but for more elaborate ones I would use a dedicated tool like seaborn.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  340069538
Powered by Datasette · Queries took 0.894ms · About: xarray-datasette