issue_comments: 405447950
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/2277#issuecomment-405447950 | https://api.github.com/repos/pydata/xarray/issues/2277 | 405447950 | MDEyOklzc3VlQ29tbWVudDQwNTQ0Nzk1MA== | 6164157 | 2018-07-17T03:26:20Z | 2018-07-17T03:26:20Z | CONTRIBUTOR | I don't have an opinion about naming variables and would be happy with whatever decision y'all make. For the code -- I added tests and changed the logic a bit. Following @dcherian's suggestion, now the default behavior is no longer coloring hues with discrete values (legend) but rather with a continuous scale (colorbar). It does make actually more sense and I think it should also be the default behavior for regular line plots. This is the API now:
Specifying If you want a discrete legend even for numeric I am a bit bothered by the fact that this is not only a different coloring method, it's a very different style altogether (under the hood using Of course, faceting works as you think it should:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
340069538 |