issue_comments: 405289693

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2277#issuecomment-405289693 https://api.github.com/repos/pydata/xarray/issues/2277 405289693 MDEyOklzc3VlQ29tbWVudDQwNTI4OTY5Mw== 1217238 2018-07-16T15:38:08Z 2018-07-16T15:38:08Z MEMBER

It is possibly worth taking a look at the recent (not yet released) scatterplot (https://github.com/mwaskom/seaborn/pull/1436) and relplot (https://github.com/mwaskom/seaborn/pull/1477) additions to Seaborn.

seaborn.scatterplot will use hue/size rather than c/s, which is definitely more readable. One hazard is that it it means that the size argument from seaborn.FacetGrid needs to be renamed to avoid name conflicts -- it's now becoming height. Unfortunately we would also need to rename the size argument if we followed Seaborn's example.

I guess I can see the virtue in sticking with matplotlib's old c/s names, but those really are terrible names. Maybe hue/mark_size would be a good compromise? Or we could systematically switch size -> height elsewhere like Seaborn.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   340069538