issue_comments: 404872061

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2164#issuecomment-404872061 https://api.github.com/repos/pydata/xarray/issues/2164 404872061 MDEyOklzc3VlQ29tbWVudDQwNDg3MjA2MQ== 6628425 2018-07-13T15:44:20Z 2018-07-13T15:44:20Z MEMBER

Thanks @pelson, that's good to hear that you would be open to someone doing some refactoring in nc-time-axis.

@rabernat @aidanheerdegen @jbusecke I think the cleanest approach for someone interested in fixing the built-in plotting issue then would be to engage with the nc-time-axis folks to see if there is a way to enable plotting with cftime.datetime objects directly (that they would feel comfortable with). Then in xarray, modulo some logic to handle the optional imports of cftime and nc_time_axis, I think it could just be a matter of adding cftime.datetime as one of the allowed types for plotting (within here), adding some tests, and maybe a documentation example.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   324740017