issue_comments: 399522595
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/issues/2217#issuecomment-399522595 | https://api.github.com/repos/pydata/xarray/issues/2217 | 399522595 | MDEyOklzc3VlQ29tbWVudDM5OTUyMjU5NQ== | 291576 | 2018-06-22T17:42:29Z | 2018-06-22T17:42:29Z | CONTRIBUTOR | Ok, I see how you implemented it for pandas's reindex. You essentially inserted an inexact filter within For xarray, though, I think we can work around backwards compatibility by having Dataset hold specialized subclasses of Index for floating-point data types that would have the needed changes to the Index class. We can have this specialized class have some default tolerance (say 100*finfo(dtype).resolution?), and it would have its methods use the stored tolerance by default, so it should be completely transparent to the end-user (hopefully). This way, |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
329575874 |