home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 399258602

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2217#issuecomment-399258602 https://api.github.com/repos/pydata/xarray/issues/2217 399258602 MDEyOklzc3VlQ29tbWVudDM5OTI1ODYwMg== 1217238 2018-06-21T22:07:14Z 2018-06-21T22:07:14Z MEMBER

To be clear, my use-case would not be solved by join='override' (isn't that just join='left'?). I have moving nests of coordinates that can have some floating-point noise in them, but are otherwise identical.

`join='left'' will reindex all arguments to match the coordinates of the first object. In practice, that means that if coordinates differ by floating point noise, the second object would end up converted to all NaNs.

join='override' would just relabel coordinates, assuming that the shapes match. The data wouldn't change at all.

I guess another way to do this would be to include method and tolerance arguments from reindex on align, and only allow them when join='left' or join='right'. But this would be a little trickier to pass on through other functions like open_mfdataset().

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  329575874
Powered by Datasette · Queries took 5.011ms · About: xarray-datasette