issue_comments: 398150942

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2236#issuecomment-398150942 https://api.github.com/repos/pydata/xarray/issues/2236 398150942 MDEyOklzc3VlQ29tbWVudDM5ODE1MDk0Mg== 1217238 2018-06-18T18:28:58Z 2018-06-18T18:28:58Z MEMBER

Very nice!

In my implementation, bottleneck is not used when skipna=False. bottleneck would be advantageous when skipna=True as numpy needs to copy the entire array once, but I think numpy's method is still OK if skipna=False.

I think this is correct -- bottleneck does not speed up non-NaN skipping functions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   333248242