issue_comments: 394757138

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2214#issuecomment-394757138 https://api.github.com/repos/pydata/xarray/issues/2214 394757138 MDEyOklzc3VlQ29tbWVudDM5NDc1NzEzOA== 1217238 2018-06-05T15:38:05Z 2018-06-05T15:38:36Z MEMBER

The different is ImplicitToExplicitIndexingAdapter(array=NumpyIndexingAdapter(array=array([1, 2]))) vs array([1, 2]).

The challenge here is that xarray, unlike dask, keep very careful track of what types of indexing an array supports. This is important for working with various array storage systems, some of which support many types of indexing and some of which do not.

We should certainly add a short-cut that skips applying ImplicitToExplicitIndexingAdapter if data is a numpy.ndarray, on these lines in Variable.chunk(): https://github.com/pydata/xarray/blob/bc52f8aa64833d8c97f9ef5253b6a78c7033f521/xarray/core/variable.py#L816-L822

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   329251342