issue_comments: 393897686

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2107#issuecomment-393897686 https://api.github.com/repos/pydata/xarray/issues/2107 393897686 MDEyOklzc3VlQ29tbWVudDM5Mzg5NzY4Ng== 6164157 2018-06-01T14:27:48Z 2018-06-01T14:27:48Z CONTRIBUTOR

Thanks @shoyer. I fixed everything except for the coverall part, which is weird. The lines it marks as untested are the function _line_facetgrid, which the main function that performs all of the testing. I suspect that it simply doesn't run my new tests for some reason. When I run pytest locally these lines do get tested (I verified by adding print commands there). Should I add decorators like pytest.mark.somethingfor coverall to notice these tests?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   320632674