issue_comments: 393759154

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2197#issuecomment-393759154 https://api.github.com/repos/pydata/xarray/issues/2197 393759154 MDEyOklzc3VlQ29tbWVudDM5Mzc1OTE1NA== 1217238 2018-06-01T05:07:34Z 2018-06-01T05:07:34Z MEMBER

This is a good point -- the current code only really makes sense when interpolating to a higher frequency, e.g., daily -> hourly.

I do think going to higher frequencies is the main use-case for interpolation, but I don't think it needs to raise errors in this case. At the least, it would be OK to fill in the invalid values with NaN.

I think the fix might be as simple as setting bounds_error=False in these two places in xarray/core/resmample.py: https://github.com/pydata/xarray/blob/cf19528d6d2baf988ad34e024cae28361c9fd693/xarray/core/resample.py#L202 https://github.com/pydata/xarray/blob/cf19528d6d2baf988ad34e024cae28361c9fd693/xarray/core/resample.py#L341

Any interest in putting together a pull request?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   327591169