home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 393757211

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2104#issuecomment-393757211 https://api.github.com/repos/pydata/xarray/issues/2104 393757211 MDEyOklzc3VlQ29tbWVudDM5Mzc1NzIxMQ== 1217238 2018-06-01T04:51:39Z 2018-06-01T04:51:39Z MEMBER

My opinions: 1. I suppose it probably does make sense to interpolate numeric coordinates, too. So this probably doesn't need to change. 2. I do think we should drop non-numeric variables. There just isn't any way to meaningfully interpolate them (especially strings). This means we will probably need to add a check in DataArray.interp to ensure that the variable dtype is numeric and otherwise raise an error.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  320275317
Powered by Datasette · Queries took 1.492ms · About: xarray-datasette