issue_comments: 393756834

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2104#issuecomment-393756834 https://api.github.com/repos/pydata/xarray/issues/2104 393756834 MDEyOklzc3VlQ29tbWVudDM5Mzc1NjgzNA== 1217238 2018-06-01T04:48:33Z 2018-06-01T04:48:33Z MEMBER

This is very elegant and I think very close to being ready to merge.

There are two design issues that I would like to discuss first: 1. Should we interpolate both data_vars and coords or only data_vars? 2. How should we handle non-numeric variables?

The current behavior of this PR is: 1. Interpolate all variables, both data_vars and coords. 2. Non-numeric variables raise an error, because they can't be converted into float.

It might make sense to copy the behavior from Dataset.reduce: 1. Only interpolate data_vars. 2. Drop non-numeric variables instead of trying to interpolate them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   320275317