home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 393636802

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2198#issuecomment-393636802 https://api.github.com/repos/pydata/xarray/issues/2198 393636802 MDEyOklzc3VlQ29tbWVudDM5MzYzNjgwMg== 1217238 2018-05-31T18:46:33Z 2018-05-31T18:46:33Z MEMBER

Indeed, I think my fix in #1707 got this wrong.

In particular this logic is wrong: https://github.com/pydata/xarray/blob/0e21fdfc8df7433c24da08f5bb8c713864339097/xarray/backends/netCDF4_.py#L190-L192

chunksizes should not be deleted if orignal_shape is not found in encoding, but only if orginal_shape exists and is different.

Any interest in putting together a fix here? :)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  327613219
Powered by Datasette · Queries took 0.792ms · About: xarray-datasette