issue_comments: 391908588

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2180#issuecomment-391908588 https://api.github.com/repos/pydata/xarray/issues/2180 391908588 MDEyOklzc3VlQ29tbWVudDM5MTkwODU4OA== 1217238 2018-05-25T00:49:15Z 2018-05-25T00:49:15Z MEMBER

OK, looking at this more carefully ds.update(other) didn't actually change when other is a Dataset, because ds[k] = ds[k].drop(coord_names) doesn't actually drop coordinates from a Dataset. It just shows a warning now, due to iteration over a Dataset.

So maybe we can leave the current behavior as is for now (but remove the warning).

What did change is how we handle conflicts in __setitem__ (which was intentional), and how we handle conflicts in update when the new value is a dictionary (which was not intentional, but at least remained consistent with __setitem__).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   326205036