issue_comments: 391900937

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2180#issuecomment-391900937 https://api.github.com/repos/pydata/xarray/issues/2180 391900937 MDEyOklzc3VlQ29tbWVudDM5MTkwMDkzNw== 6213168 2018-05-24T23:56:55Z 2018-05-24T23:56:55Z MEMBER

I'm of the strong opinion that all joins should be outer joins unless the user explicitly says otherwise, as it's the approach least prone to do damage. I would humbly suggest considering the change for a future major release (0.11 / 0.12), with several minor releases before that printing futurewarnings.

This said, I think that changing from a right join (0.10.3) to a left join (0.10.4) will only cause breakages without providing any actual benefit in terms of user-friendliness, so we should retain the previous behaviour. A right join vaguely makes more sense IMHO as it follows the general phylosophy of dict.update() where rhs wins in case of collision.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   326205036