home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 391637781

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2174#issuecomment-391637781 https://api.github.com/repos/pydata/xarray/issues/2174 391637781 MDEyOklzc3VlQ29tbWVudDM5MTYzNzc4MQ== 5635139 2018-05-24T08:45:59Z 2018-05-24T08:45:59Z MEMBER

I added an initial attempt at allowing for supplying a dict; on isel only at first

Let me know ppl's thoughts: - Arg name? - Combine or raise if supplied with kwargs? - Is there an encapsulation leak? Should we have a user API layer which is then translated to a more robust representation (i.e. kwargs to a dict), and those be separate methods? My initial inclination is that the current approach is good and managable

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  325609580
Powered by Datasette · Queries took 0.642ms · About: xarray-datasette