issue_comments: 389884190

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2149#issuecomment-389884190 https://api.github.com/repos/pydata/xarray/issues/2149 389884190 MDEyOklzc3VlQ29tbWVudDM4OTg4NDE5MA== 1217238 2018-05-17T14:22:24Z 2018-05-17T14:22:24Z MEMBER

Yes, this would warrant an immediate bug fix release. On Thu, May 17, 2018 at 7:09 AM crusaderky notifications@github.com wrote:

In xarray 0.10.4, the dtype encoding in to_netcdf has stopped working, for all engines:

import xarray ds = xarray.Dataset({'x': ['foo', 'bar', 'baz']}) ds.to_netcdf('test.nc', encoding={'x': {'dtype': 'S1'}}) [...]

xarray/backends/netCDF4_.py in _extract_nc4_variable_encoding(variable, raise_on_invalid, lsd_okay, h5py_okay, backend, unlimited_dims) 196 if invalid: 197 raise ValueError('unexpected encoding parameters for %r backend: ' --> 198 ' %r' % (backend, invalid)) 199 else: 200 for k in list(encoding):

ValueError: unexpected encoding parameters for 'netCDF4' backend: ['dtype']

I'm still trying to figure out how the regression tests didn't pick it up and what change introduced it.

@shoyer https://github.com/shoyer I'm working on this as my top priority. Do you agree this is serious enough for an emergency re-release? (0.10.4.1 or 0.10.5, your choice)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/2149, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1o6DKXddpZGzWNVoVa3IYfXomAN4ks5tzYSMgaJpZM4UDJB8 . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   324040111