issue_comments: 387993706

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2104#issuecomment-387993706 https://api.github.com/repos/pydata/xarray/issues/2104 387993706 MDEyOklzc3VlQ29tbWVudDM4Nzk5MzcwNg== 10050469 2018-05-10T08:48:12Z 2018-05-10T08:48:12Z MEMBER

As the interpolation routine can also be used for non-uniform gridded data, I don't think passing np.arange(NN) to scipy is a good idea (it will change the result if higher order method such as 'cubic' is used).

Right. Another feature of geospatial grids is that they are regularly spaced, which is not always the case here. Forget about my idea for now.

I tested your updated branch and we now come to the same results with my test data! I took the liberty to edit your comment because in your current implementation assume_sorted is False per default.

Another wish (sorry! ;): it would be great to implement the keep_attrs kwarg as well, because interpolation often conserves the units of data. Thanks!!!!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   320275317