issue_comments: 386744768

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2104#issuecomment-386744768 https://api.github.com/repos/pydata/xarray/issues/2104 386744768 MDEyOklzc3VlQ29tbWVudDM4Njc0NDc2OA== 6815844 2018-05-04T21:53:05Z 2018-05-04T21:53:05Z MEMBER

@jhamman,

I just gave your implementation a quick skim and I think there is currently some duplication of efforts so maybe we look there to see what can be combined.

Agreed. I will try to generalize your interpolator-adaptor more.

@shoyer

perhaps we should give it a shorter name. Maybe interp?

Agreed. interp sounds nice.

Which NaN are you referring to? 1. data on the arrays being indexed 2. Coordinates on the arrays being indexed 3. Points at which to interpolate

I meant 1.

Scipy.interpolate.interp1d does not support arrays with NaN. So if we want to support this, we need to interpolate the array line by line as interpolate_na does, i.e. no vectorization. For the case of multidimensional interpolation of arrays with NaN, it is equivalent with the interpolation on non-grided data. It is possible, but the performance will significantly drop.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   320275317