home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 385839554

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2097#issuecomment-385839554 https://api.github.com/repos/pydata/xarray/issues/2097 385839554 MDEyOklzc3VlQ29tbWVudDM4NTgzOTU1NA== 1217238 2018-05-02T01:36:34Z 2018-05-02T01:36:34Z MEMBER

We internally use many inhouse array-like classes and this line is used to avoid multiple nesting. I think we can change this line to more explicit type checking.

Agreed, we should do more explicit type checking. It's a little silly to assume that every object with a .values attribute is an xarray.DataArray, xarray.Variable, pandas.Series or pandas.DataFrame.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  319329850
Powered by Datasette · Queries took 106.538ms · About: xarray-datasette