issue_comments: 385206225

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1252#issuecomment-385206225 https://api.github.com/repos/pydata/xarray/issues/1252 385206225 MDEyOklzc3VlQ29tbWVudDM4NTIwNjIyNQ== 6628425 2018-04-28T21:20:21Z 2018-04-28T21:20:55Z MEMBER

Thanks @jhamman, I think this should be ready for a final round of reviews. cftime.datetime arrays can now be accurately round-tripped if enable_cftimeindex is set to True. I also added some needed test coverage for the use of the dt accessor on arrays with cftime.datetime objects and cleaned up the test-skipping logic in test_cftimeindex.py (I no longer use a module-level importorskip).

The failures in Appveyor are due to the fact that the 32-bit Python 2.7 build is not using the latest version of cftime (instead it is using 1.0.0a3). @jhamman should we expect the version 1.0.0b1 to be available on that platform?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   205473898