issue_comments: 382924824

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2016#issuecomment-382924824 https://api.github.com/repos/pydata/xarray/issues/2016 382924824 MDEyOklzc3VlQ29tbWVudDM4MjkyNDgyNA== 1217238 2018-04-20T00:35:22Z 2018-04-20T00:35:22Z MEMBER

Well, we're not going to perfectly round-trip data that uses both _FillValue and missing_value. That isn't possible with xarray's data model.

But we should certainly not raise errors when round-tripping. I see a few reasonable options: - Don't store missing_value in encoding. This would entail removing the use of pop_to with missing_value in decode(). - Add some logic to encode() to check which of _FillValue and/or missing_value are defined. Use the attribute is defined and write it to attribute. If both are defined, ignore/drop missing_value.

As a regression test, we should verify that code.encode(coder.decode(var)) == var (including explicitly checking encoding).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   308768432