issue_comments: 381728814
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/issues/2064#issuecomment-381728814 | https://api.github.com/repos/pydata/xarray/issues/2064 | 381728814 | MDEyOklzc3VlQ29tbWVudDM4MTcyODgxNA== | 1217238 | 2018-04-16T19:55:24Z | 2018-04-16T19:55:24Z | MEMBER |
OK, in that case I think #2048 was still the right change/bug-fix, making multi-file and single-file behavior consistent. But you certainly have exposed a real issue here.
Yes, we shouldn't implicitly add a new dimensions to variables in the case where the dimension already exists in the dataset. We only need the heuristics/comparisons when an entirely new dimension is being added. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
314764258 |