issue_comments: 381651747

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2049#issuecomment-381651747 https://api.github.com/repos/pydata/xarray/issues/2049 381651747 MDEyOklzc3VlQ29tbWVudDM4MTY1MTc0Nw== 244887 2018-04-16T15:46:00Z 2018-04-16T15:47:18Z CONTRIBUTOR

I have a version of this working, but to get tests to pass I had to add the same behavior for Variable types (as the method was no longer being added from NUMPY_UNARY_METHODS). I don't think I have a very good picture of the proper use of Variables in the internal api, so I wasn't sure if it made sense to extend the behavior therein. Also I should say that on the first pass I had to do this outside of the apply_ufunc mechanism, as apply_ufunc doesn't keep attrs for Variables (thus inspiring my question above).

Just let me know if that makes sense or what alternative path seems best and I'll see if I can open a PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   313010564