issue_comments: 381278786

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2056#issuecomment-381278786 https://api.github.com/repos/pydata/xarray/issues/2056 381278786 MDEyOklzc3VlQ29tbWVudDM4MTI3ODc4Ng== 1217238 2018-04-13T22:50:56Z 2018-04-13T22:50:56Z MEMBER

Hmm. This warning message is slightly unfortunate indeed.

Currently we retain the coords, but discard attrs. That seems arbitrary?

Agreed!

I don't have a strong view. If you think that Foo(foo) should always return foo (which is often the case in pandas), then we should retain the full object.

Yes, we could defensibly go either way here.

Generally, I don't think this is an important invariant, and it certainly doesn't make sense for every type. But maybe it does make sense for Dataset, given that we do do so for DataArray: https://github.com/pydata/xarray/blob/a9d1f3a36229636f0d519eb36a8d4a7c91f6e1cd/xarray/core/dataarray.py#L205-L223

(But to be clear, this wasn't a terribly careful design decision for DataArray, either.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   314241348