issue_comments: 380844768

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1252#issuecomment-380844768 https://api.github.com/repos/pydata/xarray/issues/1252 380844768 MDEyOklzc3VlQ29tbWVudDM4MDg0NDc2OA== 6628425 2018-04-12T15:24:51Z 2018-04-12T15:24:51Z MEMBER

I can push the name change on cftime forward over the next week.

Thanks @jhamman! Once that's done, hopefully we can sure up Unidata/netcdftime#39. I think those are the last outstanding issues here.

One clean option would be to require the new cftime module (with your change) for this functionality. That way we can rely on standard behavior here.

I will wait to implement this until the name change and Unidata/netcdftime#39 go through. With Unidata/netcdftime#39 we can make the one failing test here, test_roundtrip_netcdftime_datetime_data, pass for all cftime date types.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   205473898