issue_comments: 380178000

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2049#issuecomment-380178000 https://api.github.com/repos/pydata/xarray/issues/2049 380178000 MDEyOklzc3VlQ29tbWVudDM4MDE3ODAwMA== 1217238 2018-04-10T17:12:32Z 2018-04-10T17:12:32Z MEMBER

We should probably just update astype() to preserve attributes.

Note: currently astype is directly assigning a method onto Dataset/DataArray (ugh!). https://github.com/pydata/xarray/blob/dc3eebf3a514cfdc1039b63f2a542121d1328ba9/xarray/core/ops.py#L39

It should really be switched to use a more transparent definition, e.g., a method defined in a base class, with the implementation defined by using apply_ufunc: https://github.com/pydata/xarray/blob/6402391cf206fd04c12d44773fecd9b42ea0c246/xarray/core/common.py#L748

This would make it quite easy to add keep_attrs=True.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   313010564