issue_comments: 377311169

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2028#issuecomment-377311169 https://api.github.com/repos/pydata/xarray/issues/2028 377311169 MDEyOklzc3VlQ29tbWVudDM3NzMxMTE2OQ== 1217238 2018-03-29T17:28:14Z 2018-03-29T17:28:14Z MEMBER

we're discussed this before: https://github.com/pydata/xarray/issues/934

I agree that this would be nice to support in theory. The challenge is that we would need to create (and then possibly throw away?) a pandas.Index do to the actual indexing, or use a numpy search function like np.isin(). Neither of these are very efficient.

Conceptually, I think it makes sense to support indexing on arbitrary variables, which is simply more expensive if an index is not already set. Dimension coordinates would not be special except that they have indexes created automatically.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   309691307