issue_comments: 375835173

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2011#issuecomment-375835173 https://api.github.com/repos/pydata/xarray/issues/2011 375835173 MDEyOklzc3VlQ29tbWVudDM3NTgzNTE3Mw== 6815844 2018-03-24T01:07:32Z 2018-03-24T01:07:32Z MEMBER

Some comments.

  • We need to also support a dask array. Can you update dask_array_op.rolling_window? Maybe this page would help for the implementation.

We use this here https://github.com/pydata/xarray/blob/7c2c43ce6b1792e1193635ab9b64fd248266f632/xarray/core/dask_array_ops.py#L78-L79

I suspect this would be already working, but it would be nice if we can add some test cases.

  • Maybe we can also add boundary='reflect' option to make this as similar to dask.ghost.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   308039063