issue_comments: 375833339

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2011#issuecomment-375833339 https://api.github.com/repos/pydata/xarray/issues/2011 375833339 MDEyOklzc3VlQ29tbWVudDM3NTgzMzMzOQ== 6815844 2018-03-24T00:45:25Z 2018-03-24T01:03:50Z MEMBER

Thanks for sending a PR.

is fill_value='periodic' a good api?

Maybe better API would be boundary='peiodic' (see comments), but changing the public API is not an easy task. Let's keep it now as is and decide it later.

should the fill_value keyvalue be ported to rolling?

I don't think so. I think we can keep rolling as similar to that of pandas, and this option should be specific to construct method.

should this also be mentioned in the docs for rolling (I only learned about rolling.construct yesterday)

I think at least we need to add this to the docstring of construct.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   308039063