issue_comments: 375828864

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2007#issuecomment-375828864 https://api.github.com/repos/pydata/xarray/issues/2007 375828864 MDEyOklzc3VlQ29tbWVudDM3NTgyODg2NA== 6815844 2018-03-24T00:05:08Z 2018-03-24T00:05:08Z MEMBER

I don't think the kwarg should be called fill_value - that traditionally has a specific meaning of "the value to replace NaN with".

Agreed. dask.ghost has boundaries keyword, for which we can choose between periodic, reflect, and any constant. I think this would be a good reference. Maybe we can deprecate fill_value keyword and replace it by boundaries? (I slightly regret that I choose fill_value keyword in construct).

How it's implemented - do you have a view here?

Only a slight modification of construct machinery realizes this (see #2011). I think this option should be available only in construct method (not in the traditional rolling constructor) for the sake of simplicity (according to this comment).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   307783090