issue_comments: 375810316

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2007#issuecomment-375810316 https://api.github.com/repos/pydata/xarray/issues/2007 375810316 MDEyOklzc3VlQ29tbWVudDM3NTgxMDMxNg== 5635139 2018-03-23T22:03:24Z 2018-03-23T22:03:24Z MEMBER

@fujiisoup Yes for sure - I think it would be good. I think there are two salient questions: - Where this lives in the API: Should this be under construct? I don't think the kwarg should be called fill_value - that traditionally has a specific meaning of "the value to replace NaN with". I don't understand the periodic reference, but likely I'm missing something. Could be wrap=True, or roll=True? - How it's implemented - do you have a view here? Can you use the construct machinery? Or we make a new array and run rolling over it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   307783090