home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 375750884

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2010#issuecomment-375750884 https://api.github.com/repos/pydata/xarray/issues/2010 375750884 MDEyOklzc3VlQ29tbWVudDM3NTc1MDg4NA== 5635139 2018-03-23T17:57:11Z 2018-03-23T17:57:11Z MEMBER

I think we need to document more clearly that min_periods option is just neglected if using construct method.

I also think we could label construct as advanced / experimental. It's extremely cool, but for traditional cases, it's probably more cool than required, and less well tested than the standard methods.

At the moment we say "You can use this for more advanced rolling operations, such as strided rolling, windowed rolling, convolution, short-time FFT, etc."; I'm imagining adding something like "For standard operations above, there is no need to use construct". Or adding an Experimental marker

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  308030789
Powered by Datasette · Queries took 0.652ms · About: xarray-datasette